lkml.org 
[lkml]   [2018]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] livepatch: Initialize shadow variables safely by a custom callback
On Fri 2018-04-06 17:34:20, Josh Poimboeuf wrote:
> On Thu, Apr 05, 2018 at 02:23:14PM +0200, Petr Mladek wrote:
> > @@ -150,6 +149,23 @@ static void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
> > goto exists;
> > }
> >
> > + new_shadow->obj = obj;
> > + new_shadow->id = id;
> > +
> > + if (ctor) {
> > + int err;
> > +
> > + err = ctor(obj, new_shadow->data, ctor_data);
> > + if (err) {
> > + spin_unlock_irqrestore(&klp_shadow_lock, flags);
> > + kfree(new_shadow);
> > + WARN(1,
> > + "Failed to construct shadow variable <%p, %lx>\n",
> > + obj, id);
> > + return NULL;
> > + }
> > + }
> > +
>
> I'm not sure why a constructor would return an error, though I guess it
> doesn't hurt to allow it.

It is true that constructors usually do not return an error code,
namely C++ or Java. But it is not true that they could not fail.
These languages use exceptions instead.

IMHO, the return value makes sense here.


> The WARN seems excessive though, IMO. The constructor itself can warn
> (or printk or whatever else) if it thinks its warranted.

I am just fascinated by WARN(). But you are right. I am going to
replace it with

pr_err("Failed to construct shadow variable <%p, %lx> (%d)\n",
obj, id, err);

> Also I think the 'err' variable isn't really needed.

Yup. Well, it will be needed by the pr_err() ;-)

Best Regard,
Petr

\
 
 \ /
  Last update: 2018-04-10 13:34    [W:0.091 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site