lkml.org 
[lkml]   [2018]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/2] drm/xen-front: Add support for Xen PV display frontend
On Wed, Mar 28, 2018 at 01:29:46PM +0300, Oleksandr Andrushchenko wrote:
> Hi, Daniel!
>
> I just noticed I have missed one change in the patch:
> the below must be static.
>
> On 03/28/2018 10:42 AM, Daniel Vetter wrote:
> > +enum drm_mode_status display_mode_valid(struct drm_crtc *crtc,
> > + const struct drm_display_mode *mode)
> > +{
> > + struct xen_drm_front_drm_pipeline *pipeline =
> > + container_of(crtc,
> Could you please amend the patch in attachment
> when merging, so I don't resend?

Merging is up to you, as soon as you have your commit rights.
-Daniel

>
> Thank you in advance,
> Oleksandr

> From 3a82d76bd3d954056b760e5d1d09e2f96a2786ef Mon Sep 17 00:00:00 2001
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Date: Wed, 28 Mar 2018 13:24:04 +0300
> Subject: [PATCH] drm/xen-front: Make display_mode_valid static
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
> drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c b/drivers/gpu/drm/xen/xen_drm_front_kms.c
> index 545049dfaf0a..bd676be5a0db 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_kms.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_kms.c
> @@ -273,7 +273,7 @@ static void display_update(struct drm_simple_display_pipe *pipe,
> drm_dev_exit(idx);
> }
>
> -enum drm_mode_status display_mode_valid(struct drm_crtc *crtc,
> +static enum drm_mode_status display_mode_valid(struct drm_crtc *crtc,
> const struct drm_display_mode *mode)
> {
> struct xen_drm_front_drm_pipeline *pipeline =
> --
> 2.7.4
>

> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel


--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

\
 
 \ /
  Last update: 2018-03-29 09:18    [W:0.070 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site