lkml.org 
[lkml]   [2018]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [net-next PATCH v2 08/10] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes
From
Date
On 03/27/2018 01:35 PM, Andrew Lunn wrote:
>> + } else if (slave->link_interface == RGMII_LINK_MAC_PHY) {
>> + has_phy = true;
>> + phy_mode = of_get_phy_mode(slave->node);
>> + /* if phy-mode is not present, default to
>> + * PHY_INTERFACE_MODE_RGMII
>> + */
>> + if (phy_mode < 0)
>> + phy_mode = PHY_INTERFACE_MODE_RGMII;
>
> Can only do RGMII? Maybe add a call here to
> phy_interface_mode_is_rgmii() and return -EINVAL if DT contains
> something which is not RGMII?
>
Ok. Make sense.

> Andrew
>


--
Murali Karicheri
Linux Kernel, Keystone

\
 
 \ /
  Last update: 2018-03-29 22:02    [W:0.239 / U:13.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site