lkml.org 
[lkml]   [2018]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4 02/16] riscv: Use generic free_initrd_mem.
    From
    Date
    On 28/03/18 21:36, Shea Levy wrote:
    > Signed-off-by: Shea Levy <shea@shealevy.com>
    > ---
    > arch/riscv/mm/init.c | 6 ------
    > 1 file changed, 6 deletions(-)
    >
    > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
    > index c77df8142be2..36f83fe8a726 100644
    > --- a/arch/riscv/mm/init.c
    > +++ b/arch/riscv/mm/init.c
    > @@ -62,9 +62,3 @@ void free_initmem(void)
    > {
    > free_initmem_default(0);
    > }
    > -
    > -#ifdef CONFIG_BLK_DEV_INITRD
    > -void free_initrd_mem(unsigned long start, unsigned long end)
    > -{
    > -}
    > -#endif /* CONFIG_BLK_DEV_INITRD */

    This looks like a change of behavior since the weakly defined code does
    not implement a nop.

    I'm not saying the change is wrong, but if this is a deliberate bug fix
    then we need more than an empty commit message to explain what is
    happening here.


    Daniel.

    \
     
     \ /
      Last update: 2018-03-29 11:53    [W:3.174 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site