lkml.org 
[lkml]   [2018]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[patch 7/8] dm verity fec: Check result of init_rs()
The allocation of the reed solomon control structure can fail, but
fec_alloc_bufs() ignores that and subsequent operations in dm verity use
the potential NULL pointer unconditionally.

Add a proper check and abort if init_rs() fails.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/md/dm-verity-fec.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

--- a/drivers/md/dm-verity-fec.c
+++ b/drivers/md/dm-verity-fec.c
@@ -308,8 +308,13 @@ static int fec_alloc_bufs(struct dm_veri
{
unsigned n;

- if (!fio->rs)
+ if (!fio->rs) {
fio->rs = mempool_alloc(v->fec->rs_pool, GFP_NOIO);
+ if (!fio->rs) {
+ DMERR("failed to allocate RS control structure");
+ return -ENOMEM;
+ }
+ }

fec_for_each_prealloc_buffer(n) {
if (fio->bufs[n])

\
 
 \ /
  Last update: 2018-03-28 23:03    [W:0.105 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site