[lkml]   [2018]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] debugfs: Check return value of debugfs_real_fops() for NULL

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

On Wed, Mar 28, 2018 at 07:47:53AM -0700, Manoj Gupta wrote:
> Please note that there is nothing wrong in the generated code, just
> that it confuses objtool.

Then fix the tool, the C code is correct :)

> Clang has simply omitted the statement where NULL is returned since
> the pointer was always dereferenced post inlining.

Then tell clang not to do that, like we tell gcc not to do that as that
is a foolish thing for a compiler to do when building the kernel.


greg k-h

 \ /
  Last update: 2018-03-28 20:06    [W:0.054 / U:24.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site