[lkml]   [2018]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCHv4] irqchip: arm-gic: take gic_lock when updating irq type
On Wed, 28 Mar 2018 14:42:00 +0100,
Aniruddha Banerjee wrote:
> From: Aniruddha Banerjee <>
> The kernel documentation states that the locking of the irq-chip
> registers should be handled by the irq-chip driver. In the irq-gic,
> the accesses to the irqchip are seemingly not protected and multiple
> writes to SPIs from different irq descriptors do RMW requests without
> taking the irq-chip lock. When multiple irqs call the request_irq at
> the same time, there can be a simultaneous write at the gic
> distributor, leading to a race. Acquire the gic_lock when the
> irq_type is updated.
> Cc:
> Signed-off-by: Aniruddha Banerjee <>

I've applied this after having reworked the commit log a bit.



Jazz is not dead, it just smell funny.

 \ /
  Last update: 2018-03-28 16:38    [W:0.035 / U:3.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site