[lkml]   [2018]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 16/21] kcov: imply GCC_PLUGINS and GCC_PLUGIN_SANCOV instead of select'ing them
On Mon, Mar 26, 2018 at 10:29 PM, Masahiro Yamada
<> wrote:
> As Documentation/kbuild/kconfig-language.txt notes, 'select' should be
> used with care - it forces a lower limit of another symbol, ignoring
> the dependency. In this case, KCOV can select GCC_PLUGINS even if
> 'depends on HAVE_GCC_PLUGINS' is unmet.
> 'imply' is modest enough to observe the dependency, and this makes
> sense. If you enable KCOV, you will probably want to enable
> GCC_PLUGIN_SANCOV, but it should not break the dependency.
> I also remove unneeded code, I just happened to notice.
> Signed-off-by: Masahiro Yamada <>

Reviewed-by: Kees Cook <>


Kees Cook
Pixel Security

 \ /
  Last update: 2018-03-28 13:25    [W:0.274 / U:1.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site