lkml.org 
[lkml]   [2018]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi
On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote:
> + soc {
> + pinctrl@1000000 {
> + serial_0_pins: serial0_pinmux {

Please, no underscores in the node name.

> + mux {

Fyi, you can put the pinctrl properties directly into the state node,
omitting the "mux" level.

> + pins = "gpio16", "gpio17";
> + function = "blsp_uart0";
> + bias-disable;
> + };
> + };
> +

Apart from this the patch looks good.

Regards,
Bjorn

\
 
 \ /
  Last update: 2018-03-27 19:06    [W:0.142 / U:1.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site