lkml.org 
[lkml]   [2018]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] mtd: Replace typedef with struct
Date
Am Sonntag, 18. März 2018, 18:51:23 CEST schrieb Arushi Singhal:
> Using typedef for a structure type is not suggested in Linux kernel
> coding style guidelines. Hence, occurrence of typedefs has been
> removed.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/mtd/ssfdc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c
> index 95f0bf9..8bae672 100644
> --- a/drivers/mtd/ssfdc.c
> +++ b/drivers/mtd/ssfdc.c
> @@ -54,15 +54,15 @@ SumSector 2,000 4,000 8,000 16,000 32,000 64,000 128,000 256,000
> SectorSize 512 512 512 512 512 512 512 512
> **/
>
> -typedef struct {
> +struct chs_entry {
> unsigned long size;
> unsigned short cyl;
> unsigned char head;
> unsigned char sec;
> -} chs_entry_t;
> +};
>
> /* Must be ordered by size */
> -static const chs_entry_t chs_table[] = {
> +static const struct chs_entry chs_table[] = {
> { MiB( 1), 125, 4, 4 },
> { MiB( 2), 125, 4, 8 },
> { MiB( 4), 250, 4, 8 },
>

Didn't we already talk about coding style fixes on existing code? ;-)

Thanks,
//richard

\
 
 \ /
  Last update: 2018-03-27 21:38    [W:0.112 / U:2.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site