lkml.org 
[lkml]   [2018]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support
On Fri, Mar 23, 2018 at 03:56:24PM +0000, Ioana Ciornei wrote:
>
> >
> > On Fri, Mar 23, 2018 at 10:38:56AM -0500, Ioana Ciornei wrote:
> > > +#include "fsl-mc-private.h"
> > > +
> > > +#define FSL_MC_BUS_MAX_MINORS 1
> >
> > As you only need/want one character device here, why not just use the misc
> > device api? It's much simpler, and handles all of the housekeeping for you
> > correctly. It also means I don't have to audit all of your chardev code to verify it
> > is correct :)
>
> I have considered the misc device api but the fsl-mc bus, since it is
> a platform driver, is probing before the misc char driver.

How? The misc code is just "core code" there's nothing to "probe" here.
Is this an init-call ordering issue somehow? A platform driver probe
should be after the misc core is initialized. And if not, you can
always defer your probe.

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-03-23 17:11    [W:0.106 / U:3.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site