lkml.org 
[lkml]   [2018]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
Subject[REVIEW][PATCH 00/11] ipc: Fixing the pid namespace support

While discussing a proposal by Nagarathnam Muthusamy I realized that
the ipc namespace has never been given proper pid namespace support.
In particular if objects in a single ipc namespace are accessed from
different pid namespaces they will return the wrong pids.

Then when trying to test this I discovered that definitions that are
only used in msg.c, sem.c, and shm.c are included in linux/sched.h
resulting in what should be simple local modifications requring
nearly a full kernel rebuild.

So this patchset does several things.
- Changes the types that are passed into the security hooks to struct
kern_ipc_perm because that is all the security hooks use.
- Moves definitions from include/{msg,sem,shm}.h into ipc/{msg,sem,shm}.c
So the code can be modified without excessive development time.
- Instead of storing pids as intergers stores struct pid * instead.

I took a careful look to see if it seems likely the performance
regression in credential passing that af_unix experienced after
a similar conversion would be likely, but I don't see it.

So I think the biggest concern is if someone in the last 10 years
has come to depend on the buggy behavior. If either the performance
is problematic or the there are regression caused by the change
in behavior we can revert.

Still I would like to see this fixed and I plan on merging this code.

Eric W. Biederman (11):
sem/security: Pass kern_ipc_perm not sem_array into the sem security hooks
shm/security: Pass kern_ipc_perm not shmid_kernel into the shm security hooks
msg/security: Pass kern_ipc_perm not msg_queue into the msg_queue security hooks
sem: Move struct sem and struct sem_array into ipc/sem.c
shm: Move struct shmid_kernel into ipc/shm.c
msg: Move struct msg_queue into ipc/msg.c
ipc: Move IPCMNI from include/ipc.h into ipc/util.h
ipc/util: Helpers for making the sysvipc operations pid namespace aware
ipc/shm: Fix shmctl(..., IPC_STAT, ...) between pid namespaces.
ipc/msg: Fix msgctl(..., IPC_STAT, ...) between pid namespaces
ipc/sem: Fix semctl(..., GETPID, ...) between pid namespaces

include/linux/ipc.h | 2 -
include/linux/lsm_hooks.h | 32 ++++++++--------
include/linux/msg.h | 18 ---------
include/linux/security.h | 67 ++++++++++++++++-----------------
include/linux/sem.h | 40 +-------------------
include/linux/shm.h | 23 ------------
ipc/msg.c | 54 ++++++++++++++++++---------
ipc/sem.c | 73 ++++++++++++++++++++++++++----------
ipc/shm.c | 60 +++++++++++++++++++++---------
ipc/util.c | 9 +++++
ipc/util.h | 12 ++++++
security/security.c | 32 ++++++++--------
security/selinux/hooks.c | 92 +++++++++++++++++++++++-----------------------
security/smack/smack_lsm.c | 68 +++++++++++++++++-----------------
14 files changed, 297 insertions(+), 285 deletions(-)


Eric

\
 
 \ /
  Last update: 2018-03-23 20:12    [W:1.221 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site