lkml.org 
[lkml]   [2018]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2 v2] target: drop spin_lock_assert() + irqs_disabled() combo checks
Date
On Fri, 2018-03-23 at 18:36 +0100, Sebastian Andrzej Siewior wrote:
> There are a few functions which check for if the lock is held
> (spin_lock_assert()) and the interrupts are disabled (irqs_disabled()).
> > From looking at the code, each function is static, the caller is near by
>
> and does spin_lock_irq|safe(). As Linus puts it:
>
> > It's not like this is some function that is exported to random users,
> > and we should check that the calling convention is right.
> >
> > This looks like "it may have been useful during coding to document
> > things, but it's not useful long-term".
>
> Remove those checks.

Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>



\
 
 \ /
  Last update: 2018-03-23 18:47    [W:0.154 / U:2.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site