lkml.org 
[lkml]   [2018]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: Re: [PATCH 1/2] rbd: RBD_DEV_FLAG_THICK rbd_dev_flags bit
Date
Hi Yang, 

> I am not sure is this the best way for this case, what about adding an option in "rbd map -o thick rbd/test"?

I will add such option to the rbd map command to manipulate image settings. So, the end-user
do not change the settings directly via sysfs file.

> @@ -4011,6 +4012,15 @@ static void rbd_queue_workfn(struct work_struct *work)
> goto err;
> }
>
> + /* Ignore/skip discard requests for thick-provision image */
>
> Just ignore? or return -EOPNOTSUPP?

Thanks, I think -EOPNOTSUPP is better because user programs cannot know
the result of requested operation when the kernel rbd driver ignores
discard request. The result of requested operation when the kernel rbd driver
ignores discard requests, which probably misleads the user programs.

> In addition, we should not ignore the REQ_OP_WRITE_ZEROES.

Relating to the above, the return code of REQ_OP_WRITE_ZEROS request
is also -EOPNOTSUPP instead of ignoring. I think the result of
-EOPNOTSUPP is also better for this request because the kernel
rbd driver can expect that user programs write zero data by itself.

> + spin_lock_irq(&rbd_dev->lock);
> + if (!strncmp(buf, "1", size))
> + set_bit(RBD_DEV_FLAG_THICK, &rbd_dev->flags);
> + else if (!strncmp(buf, "0", size))
> + clear_bit(RBD_DEV_FLAG_THICK, &rbd_dev->flags);
> else ?

I will add the warning message in else case.

> static DEVICE_ATTR(snap_id, S_IRUGO, rbd_snap_id_show, NULL);
> static DEVICE_ATTR(parent, S_IRUGO, rbd_parent_show, NULL);
> +static DEVICE_ATTR(thick, 0644, rbd_thick_show, rbd_thick_store);
> maybe S_IRUGO | S_IWUGO?

I will change the code by using the flags.

Regards,

--
Hitoshi Kamei

\
 
 \ /
  Last update: 2018-03-22 12:57    [W:0.118 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site