lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] percpu: Allow to kill tasks doing pcpu_alloc() and waiting for pcpu_balance_workfn()
On Wed, Mar 14, 2018 at 01:56:31PM -0700, Andrew Morton wrote:
> > + if (!is_atomic) {
> > + if (gfp & __GFP_NOFAIL)
> > + mutex_lock(&pcpu_alloc_mutex);
> > + else if (mutex_lock_killable(&pcpu_alloc_mutex))
> > + return NULL;
> > + }
>
> It would benefit from a comment explaining why we're doing this (it's
> for the oom-killer).

And, yeah, this would be great. Kirill, can you please send a patch
to add a comment there?

Thanks.

--
tejun

\
 
 \ /
  Last update: 2018-03-19 16:15    [W:0.130 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site