lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses
On Fri, Mar 16, 2018 at 05:29:02AM -0700, Joe Perches wrote:
> On Fri, 2018-03-16 at 08:41 +0100, Daniel Vetter wrote:
> > On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote:
> > > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary
> > > arguments that can be removed by creating separate functins.
> > >
> > > Create specific functions for these calls to reduce x86/64 defconfig
> > > size by ~20k.
> > >
> > > Modify the existing macros to use the specific calls.
> > >
> > > new:
> > > $ size -t drivers/gpu/drm/built-in.a | tail -1
> > > 1876562 44542 995 1922099 1d5433 (TOTALS)
> > >
> > > old:
> > > $ size -t drivers/gpu/drm/built-in.a | tail -1
> > > 1897565 44542 995 1943102 1da63e (TOTALS)
> > >
> > > Miscellanea:
> > >
> > > o intel_display requires a change to use the specific calls.
> > >
> > > Signed-off-by: Joe Perches <joe@perches.com>
> >
> > Impressed with the size of the bikeshed piled on top of this I decided to
> > cut this all short by merging it.
>
> Thanks.
>
> There was a similar patch for the DRM_DEV_ macros
> awhile ago that also reduced object code.
>
> https://lkml.org/lkml/2017/9/25/247
>
> Never applied.
>
> Want a remerge resend?

Yeah dropped out of my inbox, resending is easier. Please do so.

In case you wonder, I try to fairly intentionally drop stuff on the floor,
to force other people on dri-devel to not load everything onto me, making
me a bottleneck. But then occasionally a patch drops through all nets
because tracking mailing lists is impossible :-/
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

\
 
 \ /
  Last update: 2018-03-19 14:55    [W:0.080 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site