lkml.org 
[lkml]   [2018]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 6/9] Staging: iio: accel: adis16201: Use sign_extend32 function
On Sat, 17 Mar 2018 01:36:23 +0530
Himanshu Jha <himanshujha199640@gmail.com> wrote:

> Use sign_extned32() for 32 bit sign extending rather than hard coding.
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>

Great, applied.

Thanks,

Jonathan

> ---
> v2:
> -no change in this patch.
>
> drivers/staging/iio/accel/adis16201.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c
> index 97150ea..298bf90 100644
> --- a/drivers/staging/iio/accel/adis16201.c
> +++ b/drivers/staging/iio/accel/adis16201.c
> @@ -173,9 +173,8 @@ static int adis16201_read_raw(struct iio_dev *indio_dev,
> ret = adis_read_reg_16(st, addr, &val16);
> if (ret)
> return ret;
> - val16 &= (1 << bits) - 1;
> - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> - *val = val16;
> +
> + *val = sign_extend32(val16, bits - 1);
> return IIO_VAL_INT;
> }
>

\
 
 \ /
  Last update: 2018-03-18 09:33    [W:0.199 / U:1.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site