lkml.org 
[lkml]   [2018]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 16/36] fs: add ksys_dup{,3}() helper; remove in-kernel calls to sys_dup{,3}()
On Fri, Mar 16, 2018 at 01:48:34AM -0700, Christoph Hellwig wrote:
> On Thu, Mar 15, 2018 at 08:05:09PM +0100, Dominik Brodowski wrote:
> > Using ksys_dup() and ksys_dup3() as helper functions allows us to
> > avoid the in-kernel calls to the sys_dup() and sys_dup3() syscalls.
>
> do_dup/dup3 or kern_dup/dup3, please.

On the naming issue, see my other message from a few days ago. Concerning
the added complexity and the need-for-cleanup in init/do_mounts_initrd.c
and init/main.c, I have added the following comment:

In the near future, the fs-external callers of ksys_dup{,3}() should be
converted to call do_dup2() directly. Then, ksys_dup{,3}() can be moved
within sys_dup{,3}() again.

Thanks,
Dominik

\
 
 \ /
  Last update: 2018-03-17 18:22    [W:0.067 / U:7.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site