[lkml]   [2018]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 4.14 023/109] serial: core: mark port as initialized in autoconfig
4.14-stable review patch.  If anyone has any objections, please let me know.


From: Sebastian Andrzej Siewior <>

commit 714569064adee3c114a2a6490735b94abe269068 upstream.

This is a followup on 44117a1d1732 ("serial: core: mark port as
initialized after successful IRQ change").
Nikola has been using autoconfig via setserial and reported a crash
similar to what I fixed in the earlier mentioned commit. Here I do the
same fixup for the autoconfig. I wasn't sure that this is the right
approach. Nikola confirmed that it fixes his crash.

Fixes: b3b576461864 ("tty: serial_core: convert uart_open to use tty_port_open")
Reported-by: Nikola Ciprich <>
Tested-by: Nikola Ciprich <>
Cc: <>
Signed-off-by: Sebastian Andrzej Siewior <>
Tested-by: Nikola Ciprich <>
Acked-by: Johan Hovold <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/tty/serial/serial_core.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -1157,6 +1157,8 @@ static int uart_do_autoconfig(struct tty
uport->ops->config_port(uport, flags);

ret = uart_startup(tty, state, 1);
+ if (ret == 0)
+ tty_port_set_initialized(port, true);
if (ret > 0)
ret = 0;

 \ /
  Last update: 2018-03-16 17:51    [W:0.518 / U:1.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site