lkml.org 
[lkml]   [2018]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices
Hi Jakob,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.16-rc5]
[cannot apply to next-20180315]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Jakob-Unterwurzacher/can-ucan-add-driver-for-Theobroma-Systems-UCAN-devices/20180316-111528
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All warnings (new ones prefixed by >>):

drivers/net/can/usb/ucan.c: In function 'ucan_release_context':
>> drivers/net/can/usb/ucan.c:386:21: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'int' [-Wformat=]
"context %p (#%ld) was not allocated\n",
~~^
%d
ctx, ctx - up->tx_contexts);
~~~~~~~~~~~~~~~~~~~~~

vim +386 drivers/net/can/usb/ucan.c

376
377 static void ucan_release_context(struct ucan_priv *up,
378 struct ucan_urb_context *ctx)
379 {
380 WARN_ON_ONCE(!up->tx_contexts);
381 if (!up->tx_contexts)
382 return;
383
384 if (atomic_cmpxchg(&ctx->allocated, 1, 0) == 0) {
385 dev_warn(&up->udev->dev,
> 386 "context %p (#%ld) was not allocated\n",
387 ctx, ctx - up->tx_contexts);
388 } else {
389 atomic_inc(&up->available_tx_urbs);
390 netif_wake_queue(up->netdev);
391 }
392 }
393

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2018-03-16 08:03    [W:0.149 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site