lkml.org 
[lkml]   [2018]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue
Yes that can be done. But isn't 80 column limit more of a
historical convention?

On Fri, Mar 16, 2018 at 10:17:28AM +0000, Ian Abbott wrote:
> On 15/03/2018 18:59, Pratik Jain wrote:
> > Fixed coding style issue.
> >
> > Signed-off-by: Pratik Jain <pratik.jain0509@gmail.com>
> > ---
> > drivers/staging/comedi/drivers/ni_atmio.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
> > index b9e9ab548c4b..4e27a2959b64 100644
> > --- a/drivers/staging/comedi/drivers/ni_atmio.c
> > +++ b/drivers/staging/comedi/drivers/ni_atmio.c
> > @@ -226,8 +226,8 @@ static int ni_isapnp_find_board(struct pnp_dev **dev)
> > for (i = 0; i < ARRAY_SIZE(ni_boards); i++) {
> > isapnp_dev = pnp_find_dev(NULL,
> > ISAPNP_VENDOR('N', 'I', 'C'),
> > - ISAPNP_FUNCTION(ni_boards[i].
> > - isapnp_id), NULL);
> > + ISAPNP_FUNCTION(ni_boards[i].isapnp_id),
> > + NULL);
> > if (!isapnp_dev || !isapnp_dev->card)
> > continue;
> >
>
> I suggest splitting the expression just after the '=' to avoid going over 80
> columns.
>
> --
> -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
> -=( Web: http://www.mev.co.uk/ )=-

\
 
 \ /
  Last update: 2018-03-16 11:30    [W:0.070 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site