lkml.org 
[lkml]   [2018]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[PATCH v2 0/8] staging:iio:ade7854: Cleanup on I2C/SPI code
This patchset reworks the I2C/SPI code from meter module. The set of
patches try to reduce the code duplication and make the communication
reliable. The current version of the module had many code duplications,
which make the code more error-prone and hard to read. Jonh Syne
identified some wrong error handling and fixed it in his patches; in
this series of patches I analyzed Jonh's fixes, and use it in the new
code.

It is important to highlight that meter module is under observation, due
to the lack of hardware and the old design of the chip. However, John
has the hardware for testing and interest to help to update the code
[1]. As a result, this patchset represents the first work effort to
update the meter module in the staging.

1 - https://marc.info/?l=linux-iio&m=152046885922153&w=2

Changes in V2:
- Reorganize the patchset to make easier to backport fixes.
- Adds two commits at the beginning of the patchset. First, fixes bugs
related to wrong verification in read/write I2C operations. Second,
adjust the incorrect amount of data read.
- Removes unnecessary code in read/write functions for SPI and I2C
during the rework.

Rodrigo Siqueira (8):
staging:iio:ade7854: Fix error handling on read/write
staging:iio:ade7854: Fix the wrong number of bits to read
staging:iio:ade7854: Rework I2C write function
staging:iio:ade7854: Rework SPI write function
staging:iio:ade7854: Replace many functions for one function
staging:iio:ade7854: Rework I2C read function
staging:iio:ade7854: Rework SPI read function
staging:iio:ade7854: Remove read_reg_* duplications

drivers/staging/iio/meter/ade7854-i2c.c | 238 +++++++++-------------------
drivers/staging/iio/meter/ade7854-spi.c | 268 +++++++-------------------------
drivers/staging/iio/meter/ade7854.c | 40 ++---
drivers/staging/iio/meter/ade7854.h | 23 +--
4 files changed, 159 insertions(+), 410 deletions(-)

--
2.16.2

\
 
 \ /
  Last update: 2018-03-16 23:48    [W:0.115 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site