lkml.org 
[lkml]   [2018]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] net: ethernet: arc: Fix a potential memory leak if an optional regulator is deferred
Date
Le 16/03/2018 à 20:27, David Miller a écrit :
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Date: Wed, 14 Mar 2018 22:09:34 +0100
>
>> diff --git a/drivers/net/ethernet/arc/emac_rockchip.c b/drivers/net/ethernet/arc/emac_rockchip.c
>> index 16f9bee992fe..8ee9dfd0e363 100644
>> --- a/drivers/net/ethernet/arc/emac_rockchip.c
>> +++ b/drivers/net/ethernet/arc/emac_rockchip.c
>> @@ -169,8 +169,10 @@ static int emac_rockchip_probe(struct platform_device *pdev)
>> /* Optional regulator for PHY */
>> priv->regulator = devm_regulator_get_optional(dev, "phy");
>> if (IS_ERR(priv->regulator)) {
>> - if (PTR_ERR(priv->regulator) == -EPROBE_DEFER)
>> - return -EPROBE_DEFER;
>> + if (PTR_ERR(priv->regulator) == -EPROBE_DEFER) {
>> + ret = -EPROBE_DEFER;
>> + goto out_clk_disable;
>> + }
> Please build test your changes.
>
> There is no 'ret' variable in this function, perhaps you meant 'err'.
>
Yes, obviously, this is 'err'.

I apologize. I usually build-test all my patches before submission.
This one seems to have gone out of my normal process.

Can you fix it yourself or do you want me to re-submit?

CJ


\
 
 \ /
  Last update: 2018-03-16 21:52    [W:0.077 / U:1.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site