[lkml]   [2018]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH v4 2/7] kbuild: remove wrong 'touch' in
The comment mentions it creates autoksyms.h in case it is missing,
but the actual code touches it when it does exists.

The build system creates it anyway because <linux/export.h> and
<asm-generic/export.h> need it.

The code would not have worked as intended, and people have not
noticed it. This is a proof that we can simply remove it.

Signed-off-by: Masahiro Yamada <>
Acked-by: Nicolas Pitre <>

Changes in v4: None
Changes in v3: None
Changes in v2:
- Remove the code instead of fixing it

scripts/ | 3 ---
1 file changed, 3 deletions(-)

diff --git a/scripts/ b/scripts/
index a162258..e0dd0d5 100755
--- a/scripts/
+++ b/scripts/
@@ -48,9 +48,6 @@ case "${KCONFIG_CONFIG}" in

-# In case it doesn't exist yet...
-if [ -e "$cur_ksyms_file" ]; then touch "$cur_ksyms_file"; fi
# Generate a new ksym list file with symbols needed by the current
# set of modules.
cat > "$new_ksyms_file" << EOT
 \ /
  Last update: 2018-03-16 08:39    [W:0.074 / U:5.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site