lkml.org 
[lkml]   [2018]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses
From
Date
On Thu, 2018-03-15 at 17:05 +0200, Ville Syrjälä wrote:
> On Thu, Mar 15, 2018 at 03:04:52PM +0100, Maarten Lankhorst wrote:
> > Op 15-03-18 om 14:30 schreef Ville Syrjälä:
> > > On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote:
> > > > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary
> > > > arguments that can be removed by creating separate functins.
> > > >
> > > > Create specific functions for these calls to reduce x86/64 defconfig
> > > > size by ~20k.
> > > >
> > > > Modify the existing macros to use the specific calls.
> > > >
> > > > new:
> > > > $ size -t drivers/gpu/drm/built-in.a | tail -1
> > > > 1876562 44542 995 1922099 1d5433 (TOTALS)
> > > >
> > > > old:
> > > > $ size -t drivers/gpu/drm/built-in.a | tail -1
> > > > 1897565 44542 995 1943102 1da63e (TOTALS)
> > > >
> > > > Miscellanea:
> > > >
> > > > o intel_display requires a change to use the specific calls.
> > >
> > > How much would we lose if we move the (drm_debug&FOO) outside the
> > > functions again?

again?

> > > I'm somewhat concerned about all the function call
> > > overhead when debugs aren't even enabled.

Perhaps better to have compilation elimination
of the entire debug output instead.

I think you are discussing a different issue and
this discussion should not block this patch as
this patch has no impact other than code size
reduction.

\
 
 \ /
  Last update: 2018-03-15 16:18    [W:0.101 / U:17.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site