lkml.org 
[lkml]   [2018]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices
From
Date
On 03/13/2018 06:53 PM, Jakob Unterwurzacher wrote:
> On 13.03.18 18:44, Marc Kleine-Budde wrote:
>> On 03/13/2018 06:35 PM, Jakob Unterwurzacher wrote:
>>
>> [...]
>>
>> Please mark all multibyte values going over the USB as either le or be.
>
> This is documented in can_ucan_protocol.rst,
>
> All multi-byte integers are encoded as Little Endian.
>
> but it's probably worth mentioning here as well.

Yes, but in the code, use "__le16" and "__le32" instead of "u16" and "u32"

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-03-13 18:57    [W:0.175 / U:12.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site