lkml.org 
[lkml]   [2018]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices
From
Date
On 13.03.18 18:44, Marc Kleine-Budde wrote:
> On 03/13/2018 06:35 PM, Jakob Unterwurzacher wrote:
>
> [...]
>
> Please mark all multibyte values going over the USB as either le or be.

This is documented in can_ucan_protocol.rst,

All multi-byte integers are encoded as Little Endian.

but it's probably worth mentioning here as well.

>
> Please use standard 'net' comment style:
>
> /* this is a multiline
> * comment
> */
>
>> + struct ucan_ctl_cmd_start cmd_start;
>> + /***************************************************
>> + * Setup Bittiming
>> + * bmRequest == UCAN_COMMAND_SET_BITTIMING
>> + ***************************************************/

Understood.

Thanks,
Jakob

\
 
 \ /
  Last update: 2018-03-13 18:54    [W:0.114 / U:11.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site