lkml.org 
[lkml]   [2018]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 0/1] Open questions
From
Date
On 13.03.18 18:42, Dr. Philipp Tomsich wrote:
>
>> On 13 Mar 2018, at 18:40, Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> wrote:
>>
>>>> + /* get the urb context */
>>>> + if (WARN_ON(!context))
>>>> + return;
>>>
>>> Can this happen?
>>
>> Not unless there is a bug in the code. But we want to get a message
>> before dereferencing a pointer.
>
> Why not use BUG_ON(!context)?

I believe BUG_ON kills the kernel - the intention was to get loud
message, but we'd rather not crash the user's machine.

Best regards,
Jakob

\
 
 \ /
  Last update: 2018-03-13 18:48    [W:0.173 / U:7.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site