lkml.org 
[lkml]   [2018]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: vchiq_arm: Clear VLA warning
Hi Tobin,

> "Tobin C. Harding" <me@tobin.cc> hat am 12. März 2018 um 06:46 geschrieben:
>
>
> On Mon, Mar 12, 2018 at 12:37:53PM +1100, Tobin C. Harding wrote:
> > The kernel would like to have all stack VLA usage removed[1]. The array
> > here is fixed (declared with a const variable) but it appears like a VLA
> > to the compiler. Also, currently we are putting 768 bytes on the
> > stack. This function is only called on the error path so performance is
> > not critical, let's just allocate the memory instead of using the
> > stack. This saves stack space and removes the VLA build warning.
> >
> > kmalloc a buffer for dumping state instead of using the stack.
> >
> > [1]: https://lkml.org/lkml/2018/3/7/621
> >
> > Signed-off-by: Tobin C. Harding <me@tobin.cc>
> > ---
>
> Drop this please, leaks memory.

except from the leak, did you test this patch on a RPi?

Thanks
Stefan

>
> thanks,
> Tobin.

\
 
 \ /
  Last update: 2018-03-12 06:59    [W:0.059 / U:4.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site