lkml.org 
[lkml]   [2018]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] firmware: add a function to load optional firmware v2
From
Date
On 3/11/2018 5:05 PM, Andres Rodriguez wrote:
>> Your patch series then should also have the driver callers who you
>> want to modify to use this new API. Collect from the 802.11 folks the
>> other drivers which I think they wanted changed as well.
>
> Arend, Kalle, would love to hear your feedback.

I am not sure if it was ath10k, but Kalle will surely know. The other
driver firing a whole batch of firmware requests is iwlwifi. These
basically try to get latest firmware version and if not there try an
older one.

The brcmfmac driver I maintain is slightly different. It downloads two
distinct pieces of firmware of which one is optional for certain
configurations. Currently, my driver does two asynchronous requests for
it, but I consider changing it and only make the first request
asynchronous and the second request synchronous. You can look at the
current code in drivers/net/wireless/broadcom/brcmfmac/firmware.c.
However, I did quite some restructuring last week. Anyway, I probably
will end up using the "optional" api where appropriate.

Regards,
Arend

\
 
 \ /
  Last update: 2018-03-12 00:11    [W:0.076 / U:6.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site