lkml.org 
[lkml]   [2018]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH -tip 8/9] error-injection: Fix to not enabling preemption in pre_handler

* Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Since kprobes pre_handler doesn't need to recover preemption
> even if it modifies regs->ip anymore, this fixes to remove
> the preempt_enable_no_resched() from pre_handler.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> kernel/fail_function.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/fail_function.c b/kernel/fail_function.c
> index 21b0122cb39c..b1713521f096 100644
> --- a/kernel/fail_function.c
> +++ b/kernel/fail_function.c
> @@ -176,7 +176,6 @@ static int fei_kprobe_handler(struct kprobe *kp, struct pt_regs *regs)
> override_function_with_return(regs);
> /* Kprobe specific fixup */
> reset_current_kprobe();
> - preempt_enable_no_resched();
> return 1;
> }

So where did the matching preempt_disable() get removed? If it's the 6/9 patch,
then this patch (and 8/9) should very much be part of it.

There should be no bisection breakage in the series.

Thanks,

Ingo

\
 
 \ /
  Last update: 2018-03-10 09:23    [W:0.128 / U:3.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site