[lkml]   [2018]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ALSA: usb-audio: Fix UAC2 get_ctl request with a RANGE attribute
On Mon, 29 Jan 2018 06:37:55 +0100,
Kirill Marinushkin wrote:
> The layout of the UAC2 Control request and response varies depending on
> the request type. With the current implementation, only the Layout 2
> Parameter Block (with the 2-byte sized RANGE attribute) is handled
> properly. For the Control requests with the 1-byte sized RANGE attribute
> (Bass Control, Mid Control, Tremble Control), the response is parsed
> incorrectly.
> This commit:
> * fixes the wLength field value in the request
> * fixes parsing the range values from the response
> Fixes: 23caaf19b11e ("ALSA: usb-mixer: Add support for Audio Class v2.0")
> Signed-off-by: Kirill Marinushkin <>
> Cc: Jaroslav Kysela <>
> Cc: Takashi Iwai <>
> Cc: Jaejoong Kim <>
> Cc: Bhumika Goyal <>
> Cc: Stephen Barber <>
> Cc: Julian Scheel <>
> Cc:
> Cc:

Sorry for the late reply, as I've been (and still) off.

Does this bug actually hit on any real devices, or is it only a
logical error so far? In the former case, a Cc to stable is

In anyway, I'll review and merge it properly once after I back to



 \ /
  Last update: 2018-02-07 06:46    [W:0.052 / U:3.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site