[lkml]   [2018]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] libnvdimm: remove redundant assignment to pointer 'dev'
On Mon, Feb 5, 2018 at 10:20 AM, Ross Zwisler
<> wrote:
> On Mon, Feb 05, 2018 at 02:08:52PM +0000, Colin King wrote:
>> From: Colin Ian King <>
>> Pointer dev is being assigned a value that is never read, it is being
>> re-assigned the same value later on, hence the initialization is redundant
>> and can be removed.
>> Cleans up clang warning:
>> drivers/nvdimm/pfn_devs.c:307:17: warning: Value stored to 'dev' during
>> its initialization is never read
>> Signed-off-by: Colin Ian King <>
> Reviewed-by: Ross Zwisler <>
> More importantly this fixes a potential NULL pointer dereference. nd_pfn
> is checked for NULL a few lines down, but we would have crashed here trying to
> get nd_pfn->dev.

No we wouldn't crash. We're just calculating the address, not
de-referencing a NULL pointer.

 \ /
  Last update: 2018-02-05 19:44    [W:0.054 / U:23.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site