[lkml]   [2018]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC][PATCH] <linux/stringhash.h>: fix end_name_hash() for 64bit long
On Mon, Feb 5, 2018 at 9:32 AM, Amir Goldstein <> wrote:
> Assuming the fix is not moronic, I wouldn't even know where to begin testing
> its affects, or how to prove if there really is a problem.
> Any suggestions?

So I *think* that this was on purpose, but it's a long time ago, and
we've changed some of the hashing since.

And I think you're wrong that it's a no-op on 32-bit. It's a very
expensive and pointless multiplication there too, even if the *shift*
ends up being a nop-op.

The name hashing is pretty performance-sensitive.


 \ /
  Last update: 2018-02-05 18:37    [W:0.539 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site