lkml.org 
[lkml]   [2018]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 0/2] pci: endpoint: Fix double free in pci_epf_create()
Hello Bjorn!

On Tue, 27 Feb 2018, Bjorn Helgaas wrote:

> On Tue, Feb 27, 2018 at 10:20:30AM +0000, Lorenzo Pieralisi wrote:
> > On Tue, Feb 27, 2018 at 11:02:28AM +0100, Rolf Evers-Fischer wrote:
> > > This is version 3 of a patchset to avoid double free in function
> > > 'pci_epf_create()'.
> > >
> > > When I accidentally created a new endpoint device with an empty name,
> > > the kernel warned about "attempted to be registered with empty name!"
> > > and crashed afterwards.
> > >
> > > It turned out that the crash was not caused by the 'device_add()'
> > > function itself, but by a double kfree of 'epf->name' and 'epf'.
> > >
> > > The first patch just simplifies the code, while the second patch
> > > fixes the problem.
> > >
> > > Changes in v3:
> > > - Matched to other pending pci endpoint commits (thanks, Bjorn!)
> > > - Added "Fixes" tag in patch 2 (thanks, Andy!)
> > >
> > > Changes in v2:
> > > - Based on feedback from Lorenzo, Andy and Kishon (thanks!)
> > > - Change IDs removed
> > > - First patch completely reworked in order to eliminate the
> > > need for the second 'kstrdup' allocation and the 'kfree' of
> > > the first allocation.
> > > It was tested with name="pci_epf_test.0" and name="pci_epb":
> > > The 'epf->name' was "pci_epf_test" or "pci_epb" (=unchanged).
> > >
> > > Rolf Evers-Fischer (2):
> > > pci: endpoint: Simplify name allocation for epf device
> > > pci: endpoint: Fix kernel panic after put_device()
> > ^^^
> >
> > s/pci/PCI
> >
> > Bjorn pointed that out too, I can do it when merging the patches myself
> > just a hint in case you have to respin it again, no problem.
>
> I wonder if Rolf posted the wrong version accidentally, since he
> mentioned making these match, but I don't see anything different in
> this posting. Oh, never mind, I see the response about rebasing.
> I should have been more clear about what I was looking for.
>
> Also s/epf/EPF/, since "epf" isn't a real word.
>

It was my mistake. I should have asked you to clarify your request -
especially after detecting that rebasing the commits didn't change
anything.

Nevertheless, it seems that there will be soon a v4, where the s/pci/PCI
and the s/epf/EPF can be done along with.

Best regards,
Rolf

\
 
 \ /
  Last update: 2018-02-28 11:36    [W:0.057 / U:7.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site