lkml.org 
[lkml]   [2018]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] PCI: add vendor id for Altera
Hello Johannes,

Thanks for the patch.

I can confirm that xillybus_pcie.c compiles well with and without
including pci_ids.h. As a matter of fact, it already used
PCI_VENDOR_ID_XILINX, which is defined in pci_ids.h, without including
it directly. Hence moving PCI_VENDOR_ID_ALTERA didn't change much in
terms of the dependency on pci_ids.h.

This is a matter of convention -- I'm fine either way.

Regards,
Eli

On 27/02/18 17:42, Johannes Thumshirn wrote:
> On Tue, 2018-02-27 at 17:32 +0200, Andy Shevchenko wrote:
>
>> On Tue, Feb 27, 2018 at 3:30 PM, Johannes Thumshirn<jthumshirn@suse.de>
>> wrote:
>>
>>> Add the Altera PCI Vendor id to pci_ids.h and remove the private
>>> definitions from xillybus_pcie.c and altera-cvp.c.
>>>
>>
>>> #include<linux/pci.h>
>>> +#include<linux/pci_ids.h>
>>>
>>
>>> #include<linux/pci.h>
>>> +#include<linux/pci_ids.h>
>>>
>> Isn't pci.h includes pci_ids.h ?
>>
> It indeed is, but it won't do any harm and it's not quite clear what the
> general policy (regarding pci_ids.h) is, some drivers include it (even in
> the drivers/pci/) some don't.
>
> Bjorn, any guidance from your side?
>
> Byte,
> Johannes
>
>

\
 
 \ /
  Last update: 2018-02-27 20:53    [W:0.065 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site