lkml.org 
[lkml]   [2018]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 4/8] efi: Decode UEFI-defined IA32/X64 Error Structure GUIDs
Date
> -----Original Message-----
> From: Borislav Petkov [mailto:bp@suse.de]
> Sent: Tuesday, February 27, 2018 9:30 AM
> To: Ghannam, Yazen <Yazen.Ghannam@amd.com>
> Cc: linux-efi@vger.kernel.org; linux-kernel@vger.kernel.org;
> ard.biesheuvel@linaro.org; x86@kernel.org
> Subject: Re: [PATCH v2 4/8] efi: Decode UEFI-defined IA32/X64 Error
> Structure GUIDs
>
> On Mon, Feb 26, 2018 at 01:39:00PM -0600, Yazen Ghannam wrote:
> > @@ -45,6 +81,11 @@ void cper_print_proc_ia(const char *pfx, const struct
> cper_sec_proc_ia *proc)
> > printk("%sError Structure Type: %pUl\n", newpfx,
> > &err_info->err_type);
> >
> > + err_type = cper_get_err_type(&err_info->err_type);
> > + printk("%sError Structure Type: %s\n", newpfx,
> > + err_type < ARRAY_SIZE(cper_proc_error_type_strs) ?
> > + cper_proc_error_type_strs[err_type] : "unknown");
>
> Ah, there it is, much better. Now this tells us what component it is.
>
> So cper-arm.c does the same thing and there's a similar thing in cper.c -
> cper_print_proc_generic().
>
> Let's not tri-plicate that code pls and have a generic function instead.
>

Sure, I can do that.

Ard, is this okay?

Thanks,
Yazen
\
 
 \ /
  Last update: 2018-02-27 16:29    [W:0.091 / U:2.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site