[lkml]   [2018]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v7 5/7] fuse: Simplfiy the posix acl handling logic.
On Tue, Feb 27, 2018 at 12:53 AM, Eric W. Biederman
<> wrote:
> Rename the fuse connection flag posix_acl to cached_posix_acl as that
> is what it actually means. That fuse will cache and operate on the
> cached value of the posix acl.
> When fc->cached_posix_acl is not set, set ACL_DONT_CACHE on the inode
> so that get_acl and friends won't cache the acl values even if they
> are called.
> Replace forget_all_cached_acls with fuse_forget_cached_acls. This
> wrapper only takes effect when cached_posix_acl is true to prevent
> losing the nocache or noxattr status in when posix acls are not
> cached.

Shouldn't forget_cached_acl() be taught about ACL_DONT_CACHE? I think
it makes sense to generally not clear ACL_DONT_CACHE, since it's not
an actual acl value that needs forgetting.


 \ /
  Last update: 2018-02-27 10:01    [W:0.279 / U:4.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site