lkml.org 
[lkml]   [2018]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [07/18] thunderbolt: Handle rejected Thunderbolt devices
On Mon, Feb 26, 2018 at 12:20:29PM +0200, Mika Westerberg wrote:
> On Thu, Feb 22, 2018 at 03:17:38PM -0800, Jeremy McNicoll wrote:
> > > + if (pkg->link_info & ICM_LINK_INFO_REJECTED) {
> > > + tb_info(tb, "switch at %u.%u was rejected by ICM firmware\n",
> > > + link, depth);
> >
> > This kind of condition sounds more like an error instead of info.
> > Please bump this up to tb_WARN/tb_warn ideally tb_err().
>
> No, this is not an error.

To be more clear, it is totally fine to have the firmware to reject some
devices. For example in case of the new usbonly security level the
firmware rejects other devices but the first.

\
 
 \ /
  Last update: 2018-02-26 14:39    [W:0.103 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site