[lkml]   [2018]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'
On Sat, Feb 24, 2018 at 3:50 PM, Masahiro Yamada
<> wrote:
> As Documentation/kbuild/kconfig-language.txt notes, 'select' should be
> used with care - it forces a lower limit of another symbol, ignoring
> the dependency.
> MFD_SYSCON depends on HAS_IOMEM, but several drivers with COMPILE_TEST
> select it.
> This causes unmet dependencies for architecture without HAS_IOMEM.
> $ make ARCH=score randconfig
> scripts/kconfig/conf --randconfig Kconfig
> selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
> Use 'depends on' to observe the dependency.
> This commit was created by the following command:
> $ find drivers -name 'Kconfig*' | xargs sed -i -e \
> 's/select MFD_SYSCON$/depends on MFD_SYSCON/'
> Then, COMMON_CLK_NXP and S3C2410_WATCHDOG were fixed up manually.
> Also, make MFD_SYSCON 'default y' because some defconfig files may
> rely on someone select's MFD_SYSCON.
> Signed-off-by: Masahiro Yamada <>
> ---
> If you have a better idea to fix 'unmet dependencies',
> please suggest.

Changing 'select MFD_SYSCON' to 'depends on' will definitely break lots
of defconfig configurations, I'd rather not do that.

Only score, tile and um have some configurations that select 'NO_IOMEM'.
Score is getting removed now, tile might get removed later (we could make
PCI mandatory in the meantime to avoid that configuration), and I think for
um, we already have a workaround for the NO_IOMEM dependencies
(I forget the details).


 \ /
  Last update: 2018-02-26 09:44    [W:0.102 / U:6.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site