lkml.org 
[lkml]   [2018]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V5 12/17] perf evsel: expose perf_missing_features.write_backward
Date
> Em Thu, Jan 18, 2018 at 01:26:27PM -0800, kan.liang@intel.com escreveu:
> > From: Kan Liang <kan.liang@intel.com>
> >
> > perf top need it to handle overwrite fallback later.
> >
> > Signed-off-by: Kan Liang <kan.liang@intel.com>
> > ---
> > tools/perf/util/evsel.c | 5 +++++
> > tools/perf/util/evsel.h | 2 ++
> > 2 files changed, 7 insertions(+)
> >
> > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index
> > 4eea3b4..1dd3700 100644
> > --- a/tools/perf/util/evsel.c
> > +++ b/tools/perf/util/evsel.c
> > @@ -1670,6 +1670,11 @@ static bool ignore_missing_thread(struct
> perf_evsel *evsel,
> > return true;
> > }
> >
> > +bool is_write_backward_fail(void)
> > +{
> > + return perf_missing_features.write_backward;
> > +}
> > +
>
> Humm, I think we better expose perf_missing_features, i.e. tools using
>
> if (perf_missing_features.write_backward)
>

It looks good.
Thanks a lot.

Kan

> looks more clear than:
>
> if (is_write_backward_fail())
>
> This is minor, so I'm doing this myself, please holler if you disagree.
>
> - Arnaldo
>
> > int perf_evsel__open(struct perf_evsel *evsel, struct cpu_map *cpus,
> > struct thread_map *threads)
> > {
> > diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h index
> > 846e416..1f46728 100644
> > --- a/tools/perf/util/evsel.h
> > +++ b/tools/perf/util/evsel.h
> > @@ -448,4 +448,6 @@ int perf_event_attr__fprintf(FILE *fp, struct
> > perf_event_attr *attr,
> >
> > struct perf_env *perf_evsel__env(struct perf_evsel *evsel);
> >
> > +bool is_write_backward_fail(void);
> > +
> > #endif /* __PERF_EVSEL_H */
> > --
> > 2.5.5

\
 
 \ /
  Last update: 2018-02-02 15:54    [W:0.054 / U:5.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site