lkml.org 
[lkml]   [2018]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/12] i2c: qup: remove redundant variables for BAM SG count
On 2018-02-09 07:46, Sricharan R wrote:
> Hi Abhishek,
>
> On 2/3/2018 1:28 PM, Abhishek Sahu wrote:
>> The rx_nents and tx_nents are redundant. rx_buf and tx_buf can
>> be used for total number of SG entries.
>>
>> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
>> ---
>> drivers/i2c/busses/i2c-qup.c | 26 ++++++++++----------------
>> 1 file changed, 10 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-qup.c
>> b/drivers/i2c/busses/i2c-qup.c
>> index c68f433..bb83a2967 100644
>> --- a/drivers/i2c/busses/i2c-qup.c
>> +++ b/drivers/i2c/busses/i2c-qup.c
>> @@ -692,7 +692,7 @@ static int qup_i2c_bam_do_xfer(struct qup_i2c_dev
>> *qup, struct i2c_msg *msg,
>> struct dma_async_tx_descriptor *txd, *rxd = NULL;
>> int ret = 0, idx = 0, limit = QUP_READ_LIMIT;
>> dma_cookie_t cookie_rx, cookie_tx;
>> - u32 rx_nents = 0, tx_nents = 0, len, blocks, rem;
>> + u32 len, blocks, rem;
>> u32 i, tlen, tx_len, tx_buf = 0, rx_buf = 0, off = 0;
>> u8 *tags;
>>
>
> This is correct. Just a nit, may be rx/tx_buf can be changed to
> rx/tx_count to make it more clear.
>

Yes, rx/tx_count will be more meaningful. rx/tx_buf gives the
impression that it is uchar buffer. I will change that.

Thanks,
Abhishek

\
 
 \ /
  Last update: 2018-02-19 11:27    [W:0.059 / U:3.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site