Messages in this thread |  | | From | Philippe Ombredanne <> | Date | Sun, 18 Feb 2018 18:31:14 +0100 | Subject | Re: [PATCH v4] rtc: isl12026: Add driver. |
| |
Hi David,
On Fri, Feb 16, 2018 at 8:44 PM, David Daney <david.daney@cavium.com> wrote: > The ISL12026 is a combination RTC and EEPROM device with I2C > interface. The standard RTC driver interface is provided. The EEPROM > is accessed via the NVMEM interface via the "eeprom0" directory in the > sysfs entry for the device. > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: David Daney <david.daney@cavium.com>
<snip>
> --- /dev/null > +++ b/drivers/rtc/rtc-isl12026.c > @@ -0,0 +1,529 @@ > +// SPDX-License-Identifier: GPL-2.0
<snip>
> +MODULE_LICENSE("GPL");
Your MODULE_LICENSE does not match your SPDX tag. Per module.h, GPL would mean GPL-2.0+ not GPL-2.0 It would be best if you can sync the two.
-- Cordially Philippe Ombredanne
|  |