[lkml]   [2018]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Seeking guidance on spelling fixes
On 02/18/2018 07:34 AM, David Frey wrote:
> I noticed a common spelling mistake in some Linux kernel code that I was
> reading the other day and it made me wonder how prevalent common spelling
> mistakes are in the kernel. I did some grepping and it seems that there
> are a large number of spelling mistakes. I did a bit of searching and I
> found ( which includes some comments/tools
> relating to spelling and the Linux kernel.
> I have gone ahead and corrected about 100 total instances based on 25
> common misspellings. There are many, many more common misspellings that I
> could check, but I don't want to sink more time into this if the changes
> won't be accepted.
> Is this type of change likely to be accepted? Right now I am making
> individual git commits for each correction. For example "aditional ->
> additional". I figured that it would be easier to review the list of
> replacements rather than a mega-patch which fixes many different errors.
> This way if any of the changes are controversial, I can easily rebase them
> out.
> I am trying to only correct true misspellings. I'm not trying to choose
> the "most correct" spelling for cases where there are acceptable alternate
> spellings.
> I've pushed the changes I have made so far to a "spelling_fixes" branch
> here: just in case
> there is any question about what I am doing based on the above description.
> Just to be clear, I'm not trying to get this portion of the work merged at
> this point. I'm trying to get a feel for whether I should keep working on
> this.

I can't answer for others, of course, but fixing spelling in user-visible
messages will usually be accepted/merged (e.g., error messages or Kconfig
help text). I looked at a few of the commits and they are fixes in comments.
I would accept them, but I'm not a maintainer, just a contributor.


 \ /
  Last update: 2018-02-18 18:01    [W:0.040 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site