lkml.org 
[lkml]   [2018]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] iio: chemical: ccs811: Typo correction in HW_ID_VALUE constant define naming
On Tue, 13 Feb 2018 22:36:57 +0000
Richard Lai <richard@richardman.com> wrote:

> This particular constant was named with prefix "CCS881", which should be
> "CCS811" instead, just like the rest of constant names in the file, as this
> driver implementation is for AMS CCS811 sensor. "CCS881" could literally be
> referring to another sensor product unrelated to AMS CCS811 sensor.
>
> Signed-off-by: Richard Lai <richard@richardman.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
> drivers/iio/chemical/ccs811.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/chemical/ccs811.c b/drivers/iio/chemical/ccs811.c
> index 840a6cb..8e8beb7 100644
> --- a/drivers/iio/chemical/ccs811.c
> +++ b/drivers/iio/chemical/ccs811.c
> @@ -31,7 +31,7 @@
> #define CCS811_ALG_RESULT_DATA 0x02
> #define CCS811_RAW_DATA 0x03
> #define CCS811_HW_ID 0x20
> -#define CCS881_HW_ID_VALUE 0x81
> +#define CCS811_HW_ID_VALUE 0x81
> #define CCS811_HW_VERSION 0x21
> #define CCS811_HW_VERSION_VALUE 0x10
> #define CCS811_HW_VERSION_MASK 0xF0
> @@ -315,7 +315,7 @@ static int ccs811_probe(struct i2c_client *client,
> if (ret < 0)
> return ret;
>
> - if (ret != CCS881_HW_ID_VALUE) {
> + if (ret != CCS811_HW_ID_VALUE) {
> dev_err(&client->dev, "hardware id doesn't match CCS81x\n");
> return -ENODEV;
> }

\
 
 \ /
  Last update: 2018-02-17 15:13    [W:0.064 / U:8.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site