lkml.org 
[lkml]   [2018]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] lib/scatterlist: Add SG_CHAIN and SG_EMARK macros for LSB encodings
Date
On Wed, 2018-02-14 at 10:28 +0530, Anshuman Khandual wrote:
> +#define SG_CHAIN 0x01
> +#define SG_EMARK 0x02

Hello Anshuman,

As you probably know constants that do not have a suffix are of type int. Please
consider to add suffix "UL" to these constants to avoid that the compiler could
take an undesired decision when e.g. converting ~SG_CHAIN from int to unsigned
long.

Thanks,

Bart.
\
 
 \ /
  Last update: 2018-02-14 17:04    [W:0.137 / U:25.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site