lkml.org 
[lkml]   [2018]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] auxdisplay: img-ascii-lcd: kconfig: Remove MIPS_SEAD3 reference
On Sun, Feb 11, 2018 at 5:40 PM, Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
> On Sat, Feb 10, 2018 at 3:14 PM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
>> Commit 3f5f0a4475e1 ("MIPS: generic: Convert SEAD-3 to a generic board")
>> removed the MIPS_SEAD3 symbol and moved the setting of IMG_ASCII_LCD to
>> the board-sead-3.config defconfig file, but IMG_ASCII_LCD still
>> references the removed MIPS_SEAD3 symbol.
>>
>> Remove the reference.
>>
>> Discovered with the
>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
>> script.
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>> ---
>> Changes in v2:
>>
>> - The wrong commit was referenced in the commit message.
>>
>> - Mention that IMG_ASCII_LCD is now set via the board-sead-3.config defconfig
>> file.
>>
>> - Clarify that Kconfig is involved. The previous commit title was
>> "auxdisplay: img-ascii-lcd: Remove MIPS_SEAD3 reference".
>>
>
> Thanks for the new version!
>
> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>

To clarify, I am picking this patch up for my queue (sorry for any confusion!).

>
>>
>> drivers/auxdisplay/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
>> index 2c2ed9cf8796..3cba78d36eec 100644
>> --- a/drivers/auxdisplay/Kconfig
>> +++ b/drivers/auxdisplay/Kconfig
>> @@ -137,7 +137,7 @@ config CFAG12864B_RATE
>> config IMG_ASCII_LCD
>> tristate "Imagination Technologies ASCII LCD Display"
>> depends on HAS_IOMEM
>> - default y if MIPS_MALTA || MIPS_SEAD3
>> + default y if MIPS_MALTA
>> select SYSCON
>> help
>> Enable this to support the simple ASCII LCD displays found on
>> --
>> 2.14.1
>>

\
 
 \ /
  Last update: 2018-02-12 14:52    [W:0.358 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site