lkml.org 
[lkml]   [2018]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 4/8] ASoC: samsung: i2s: Define the parameters list for SAMSUNG_I2S_OPCLK
On Wed, Feb 7, 2018 at 5:23 PM, Sylwester Nawrocki
<s.nawrocki@samsung.com> wrote:
> On 02/06/2018 01:26 PM, Krzysztof Kozlowski wrote:
>> On Mon, Feb 5, 2018 at 4:43 PM, Sylwester Nawrocki
>> <s.nawrocki@samsung.com> wrote:
>
>>> diff --git a/sound/soc/samsung/i2s.h b/sound/soc/samsung/i2s.h
>>> index 79781de2f247..a9832a9555cb 100644
>>> --- a/sound/soc/samsung/i2s.h
>>> +++ b/sound/soc/samsung/i2s.h
>>> @@ -16,11 +16,16 @@
>>> #define SAMSUNG_I2S_DAI "samsung-i2s"
>>> #define SAMSUNG_I2S_DAI_SEC "samsung-i2s-sec"
>>>
>>> -#define SAMSUNG_I2S_DIV_BCLK 1
>>> +#define SAMSUNG_I2S_DIV_BCLK 1
>>>
>>> -#define SAMSUNG_I2S_RCLKSRC_0 0
>>> -#define SAMSUNG_I2S_RCLKSRC_1 1
>>> +#define SAMSUNG_I2S_RCLKSRC_0 0
>>> +#define SAMSUNG_I2S_RCLKSRC_1 1
>>> #define SAMSUNG_I2S_CDCLK 2
>>> +/* Operation clock for IIS logic */
>>> #define SAMSUNG_I2S_OPCLK 3
>>> +#define SAMSUNG_I2S_OPCLK_CDCLK_OUT 0 /* CODEC clock out */
>>> +#define SAMSUNG_I2S_OPCLK_CDCLK_IN 1 /* CODEC clock in */
>>> +#define SAMSUNG_I2S_OPCLK_BCLK_OUT 2 /* Bit clock out */
>>> +#define SAMSUNG_I2S_OPCLK_PCLK 3 /* Audio bus clock */
>>>
>>> #endif /* __SND_SOC_SAMSUNG_I2S_H */
>>
>> This part of patch seems to be unrelated (and it includes some cleanups).
>
> This is actually the main part of the patch, an API exported to other
> drivers.

You are right, I looked at it without the context of 5/8 and I assumed
you are changing existing user of the defines...

> The whitespace changes are for keeping the alignment uniform,
> I could just drop them.

Let it be then.

Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2018-02-12 11:01    [W:0.051 / U:3.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site