Messages in this thread |  | | Date | Sun, 11 Feb 2018 21:39:05 +0000 (GMT) | From | James Simmons <> | Subject | Re: [PATCH] staging: lustre: lnet: return of an error code should be negative |
| |
> Return value of error codes should typically be negative. > Issue reported by checkpatch.pl >
Reviewed-by: James Simmons <jsimmons@infradead.org>
> Signed-off-by: Sumit Pundir <pundirsumit11@gmail.com> > --- > drivers/staging/lustre/lnet/selftest/framework.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lnet/selftest/framework.c b/drivers/staging/lustre/lnet/selftest/framework.c > index c7697f6..0ca1e3a 100644 > --- a/drivers/staging/lustre/lnet/selftest/framework.c > +++ b/drivers/staging/lustre/lnet/selftest/framework.c > @@ -187,7 +187,7 @@ sfw_del_session_timer(void) > return 0; > } > > - return EBUSY; /* racing with sfw_session_expired() */ > + return -EBUSY; /* racing with sfw_session_expired() */ > } > > static void > -- > 2.7.4 > >
|  |