lkml.org 
[lkml]   [2018]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] x86/Kconfig: Further simplify the NR_CPUS config
Date
On 02/10/2018 02:19 PM, Linus Torvalds wrote:
> Looks good to me.
>
> At the risk of bike-shedding, we could remove all the
>
> default 1 if !SMP
>
> from the BEGIN/END/DEFAULT things, and perhaps just keep that part in NR_CPUS.
>
> I didn't check, but I *think* it would work to just do
>
> config NR_CPUS
> int "Maximum number of CPUs" if SMP && !MAXSMP
> range NR_CPUS_RANGE_BEGIN NR_CPUS_RANGE_END
> default "1" if !SMP
> default NR_CPUS_DEFAULT
>
> but maybe the "range" line would need an "if !SMP" on it too to avoid
> the issue with "1" being out of range.,

Yeah, I had an early test that failed due to something like that.


--
~Randy

\
 
 \ /
  Last update: 2018-02-11 02:44    [W:0.078 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site